[lld] c5578fc - [ELF][test] Improve linkerscript/entry.s

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2022-06-25T12:14:47-07:00
New Revision: c5578fca16d5e2b274a9bd44e59f5160e908e294

URL: https://github.com/llvm/llvm-project/commit/c5578fca16d5e2b274a9bd44e59f5160e908e294
DIFF: https://github.com/llvm/llvm-project/commit/c5578fca16d5e2b274a9bd44e59f5160e908e294.diff

LOG: [ELF][test] Improve linkerscript/entry.s

Added: 
    

Modified: 
    lld/test/ELF/linkerscript/entry.s

Removed: 
    


################################################################################
diff  --git a/lld/test/ELF/linkerscript/entry.s b/lld/test/ELF/linkerscript/entry.s
index 15ad313c8056f..ecf052b3548a7 100644
--- a/lld/test/ELF/linkerscript/entry.s
+++ b/lld/test/ELF/linkerscript/entry.s
@@ -1,19 +1,17 @@
 # REQUIRES: x86
 
-# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
+# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
 
 # RUN: echo "ENTRY(_label)" > %t.script
-# RUN: ld.lld -o %t2 %t.script %t
-# RUN: llvm-readobj %t2 > /dev/null
+# RUN: ld.lld %t.script %t.o -o %t
+# RUN: llvm-readelf -hs %t | FileCheck %s
 
-# The entry symbol should not cause an undefined error.
-# RUN: echo "ENTRY(_wrong_label)" > %t.script
-# RUN: ld.lld -o %t2 %t.script %t
-# RUN: ld.lld --entry=abc -o %t2 %t
+# CHECK: Entry point address: 0x[[#%x,ENTRY:]]
+# CHECK: [[#]]: {{0*}}[[#ENTRY]]   0 NOTYPE  GLOBAL DEFAULT [[#]] _label
 
-# -e has precedence over linker script's ENTRY.
+## -e overrides the ENTRY command.
 # RUN: echo "ENTRY(_label)" > %t.script
-# RUN: ld.lld -e _start -o %t2 %t.script %t
+# RUN: ld.lld -e _start -o %t2 %t.script %t.o
 # RUN: llvm-readobj --file-headers --symbols %t2 | \
 # RUN:   FileCheck -check-prefix=OVERLOAD %s
 
@@ -21,17 +19,16 @@
 # OVERLOAD: Name: _start
 # OVERLOAD-NEXT: Value: [[ENTRY]]
 
-# The entry symbol can be a linker-script-defined symbol.
+## The entry symbol can be a linker-script-defined symbol.
 # RUN: echo "ENTRY(foo); foo = 1;" > %t.script
-# RUN: ld.lld -o %t2 %t.script %t
-# RUN: llvm-readobj --file-headers --symbols %t2 | \
-# RUN:   FileCheck -check-prefix=SCRIPT %s
+# RUN: ld.lld -o %t %t.script %t.o
+# RUN: llvm-readobj --file-headers --symbols %t | FileCheck --check-prefix=SCRIPT %s
 
 # SCRIPT: Entry: 0x1
 
+## An undefined entry symbol causes a warning.
 # RUN: echo "ENTRY(no_such_symbol);" > %t.script
-# RUN: ld.lld -o %t2 %t.script %t 2>&1 | \
-# RUN:   FileCheck -check-prefix=MISSING %s
+# RUN: ld.lld %t.script %t.o -o /dev/null 2>&1 | FileCheck --check-prefix=MISSING %s
 
 # MISSING: warning: cannot find entry symbol no_such_symbol