[PATCH] D127083: [MCA] Introducing incremental SourceMgr and resumable pipeline

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/unittests/tools/llvm-mca/MCATestBase.cpp:85
+        // Default case.
+        return std::move(NewE);
+      }
----------------
This is causing failures:
https://lab.llvm.org/buildbot/#/builders/57/builds/19267

```
/home/buildbots/docker-RHEL-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/llvm/unittests/tools/llvm-mca/MCATestBase.cpp:85:16: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
        return std::move(NewE);
               ^
/home/buildbots/docker-RHEL-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/llvm/unittests/tools/llvm-mca/MCATestBase.cpp:85:16: note: remove std::move call here
        return std::move(NewE);
               ^~~~~~~~~~    ~
1 error generated.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127083/new/

https://reviews.llvm.org/D127083