[PATCH] D128474: [BOLT] Support multiple parents for split jump table

[Huan Nguyen via Phabricator via llvm-commits]

nhuhuan added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:573
     if (Value == BF.getAddress() + BF.getSize()) {
-      addOffset(Value - BF.getAddress());
+      addOffset(Value);
       HasUnreachable = true;
----------------
rafauler wrote:
> Same renaming here (my motivation here is why are we calling this an offset if this is not an offset anymore)
Offset is a general term.
For PIC, it is the offset to the program start. Definitely not "absolute address".
For NoPIC, it is the offset to process's memory start.





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128474/new/

https://reviews.llvm.org/D128474