[PATCH] D128558: [BOLT] Mark option values of --split-functions deprecated

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/lib/Passes/SplitFunctions.cpp:35
+      Value = true;
+      errs() << formatv("BOLT-WARNING: specifying non-boolean value for option "
+                        "-{0} is deprecated\n",
----------------
FPar wrote:
> Amir wrote:
> > Non-boolean values are deprecated, but would they still be accepted?
> > Also, to make that warning stand out, please use `WithColor::warning()` (see example use in D126722).
> Yes, this patch does not change the behavior when passing "2" or "3" to -split-functions. The only visible change is the warning being emitted.
We discussed the `WithColor::warning()` change offline and agreed it's a good idea to have it, but it has to be done in a consistent manner for all BOLT output. It's fine to keep `errs()` for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128558/new/

https://reviews.llvm.org/D128558