[PATCH] D125212: [GlobalISel] Implement the HasNoUse builtin predicate

Fri Jun 24 15:41:32 PDT 2022

arsenm added inline comments.

================
Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:803

+  // TODO: Support this in SelectionDAG.
+  // If set to true, a predicate is added that checks for the absence of use of
----------------
abinavpp wrote:
> arsenm wrote:
> > Not sure how you can avoid supporting it here?
> I assume we're good with the changes for GlobalISel (including D128241 and D125213). Should I add the SelectionDAG support in this patch?
Yes. I think not having the predicate work in both would be confusingly divergent. I think the DAG path is easier to handle since it's just dumb C++ emission

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125212/new/

https://reviews.llvm.org/D125212