[PATCH] D128558: [BOLT] Mark option values of --split-functions deprecated
Amir Ayupov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 24 14:42:45 PDT 2022
Amir added inline comments.
================
Comment at: bolt/lib/Passes/SplitFunctions.cpp:35
+ Value = true;
+ errs() << formatv("BOLT-WARNING: specifying non-boolean value for option "
+ "-{0} is deprecated\n",
----------------
Non-boolean values are deprecated, but would they still be accepted?
Also, to make that warning stand out, please use `WithColor::warning()` (see example use in D126722).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128558/new/
https://reviews.llvm.org/D128558
More information about the llvm-commits
mailing list