[PATCH] D126980: [Symbolize] Add log markup --filter to llvm-symbolizer.

Fri Jun 24 14:16:04 PDT 2022

mysterymath added a comment.

In D126980#3604389 <https://reviews.llvm.org/D126980#3604389>, @peter.smith wrote:

> Only a few small comments. May be worth calling Filter.cpp and Filter.h MarkupFilter.cpp and MarkupFilter.h as there could be non-markup based filters in the future. Not a strong opinion as these filenames could be changed later if needed.

I like MarkupFilter as a name; especially as a pair for MarkupNode and MarkupParser. I've renamed the files and classes to match.

> Could be worth adding to the release notes as a new feature for llvm-symbolizer.

Done.

================
Comment at: llvm/docs/CommandGuide/llvm-symbolizer.rst:250

+.. option:: --filter
+
----------------
peter.smith wrote:
> Looking forward, is it possible that the symbolizer might support more than one markup, and would it change the interface? My thoughts are that we could introduce another parameter --filter-markup=<llvm | something-else> which could default to the LLVM Markup syntax, so using `--filter` isn't a problem.
I actually like `--filter-markup` better as the command line option; it's clearer from the invocation what it's going to do. This also allows us to later backwards-compatibly add an `--filter-markup=` version of the flag, and the non-equals version can default to `llvm`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126980/new/

https://reviews.llvm.org/D126980