[PATCH] D128474: [BOLT] Support multiple parents for split jump table

[Amir Ayupov via Phabricator via llvm-commits]

Amir added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:645
+                         NextJTAddress, &JT->OffsetEntries);
     if (!Success) {
+      LLVM_DEBUG(ListSeparator LS;
----------------
Let's move the body under !Success into 
```LLVM_DEBUG({
  ...
});```
block, except `llvm_unreachable` at the end


================
Comment at: bolt/lib/Core/BinaryContext.cpp:830
   Function.JumpTables.emplace(Address, JT);
-
+  JT->print(outs());
   return JTLabel;
----------------
Please remove that print


================
Comment at: bolt/test/X86/split-func-jump-table-fragment-bidirection.s:14
 # CHECK: BOLT-WARNING: Multiple fragments access same jump table: main; main.cold.1
+# CHECK: PIC Jump table JUMP_TABLE1 for function main, main.cold.1 at 0x2e0 with a total count of 0:
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128474/new/

https://reviews.llvm.org/D128474