[PATCH] D128526: [BOLT][DWARF] Add support for DW_AT_call_pc/DW_AT_call_return_pc

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb accepted this revision.
maksfb added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:483
+    case dwarf::DW_TAG_call_site: {
+      auto patchPC = [&](AttrInfo &AttrVal, StringRef Entry) -> void {
+        Optional<uint64_t> Address = AttrVal.V.getAsAddress();
----------------



================
Comment at: bolt/lib/Rewrite/DWARFRewriter.cpp:483
+    case dwarf::DW_TAG_call_site: {
+      auto patchPC = [&](AttrInfo &AttrVal, StringRef Entry) -> void {
+        Optional<uint64_t> Address = AttrVal.V.getAsAddress();
----------------
maksfb wrote:
> 
You can use dwarf::AttributeString() to convert attribute value to string. Not sure if that will be enough or worth it to eliminate the `Entry` parameter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128526/new/

https://reviews.llvm.org/D128526