[PATCH] D128322: [GuardWidening] Use logical and in widenCondCommon as it stated in doc

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 10:44:54 PDT 2022


skatkov added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/GuardWidening.cpp:601
+    Value *AndLHS, *AndRHS;
+    if (match(CheckCond, m_LogicalAnd(m_Value(AndLHS), m_Value(AndRHS))))
+      return parseRangeChecks(AndLHS, Checks) &&
----------------
nikic wrote:
> m_LogicalAnd also matches m_And, so you can drop the code above.
Thanks, will update on Monday.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128322/new/

https://reviews.llvm.org/D128322



More information about the llvm-commits mailing list