[PATCH] D127778: [LTO][ELF] Add selective --save-temps= option

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 10:42:33 PDT 2022


tejohnson added a comment.

In D127778#3603536 <https://reviews.llvm.org/D127778#3603536>, @MaskRay wrote:

> From a layering perspective, the feature is better tested on the llvm/ project, not lld/. You may need to change llvm-lto2 to check the values. Having tests in lld/test/ELF is fine too as that reflects how people use the functionality, but they should not be replacement for llvm/ side tests.
> (llvm/test/ThinLTO/X86 and llvm/test/LTO/X86)

This is a good point, and for D127779 <https://reviews.llvm.org/D127779> as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127778/new/

https://reviews.llvm.org/D127778



More information about the llvm-commits mailing list