[PATCH] D125485: [ArgPromotion] Unify byval promotion with non-byval

[Pavel Samolysov via Phabricator via llvm-commits]

psamolysov added a comment.

@nikic I believe this is a very good idea just to drop the legacy PM support in ArgPromotion. Thank you for the patch, once your patch has been landed, I'll just leave the single `DTGetter`.

> We should be fetching AssumptionCache for the new function rather than the old function as well.

With `AssumptionCache` there should be no problem with the legacy PM because the following construct is supported:

  getAnalysis<AssumptionCacheTracker>().getAssumptionCache(*OldF)

I've added the `ACGetter` lambdas to the modern pass as well as the legacy one and I'm ready to remove the getter for the legacy pass as soon as the pass has been removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125485/new/

https://reviews.llvm.org/D125485