[PATCH] D114650: [SCEV] Construct SCEV iteratively (WIP).

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 439764.
fhahn added a comment.
Herald added a subscriber: nlopes.

Rebased and updated to keep recursive handling of phi nodes for now. I think this is as strippped down as possible for an initial version. Compile-time impact is more managable than for the initial version:

NewPM-O3: +0.11%
NewPM-ReleaseThinLTO: +0.12%
NewPM-ReleaseLTO-g: +0.08%

https://llvm-compile-time-tracker.com/compare.php?from=9d2349c78f93cba78c1f3b770355f2ac0cb98163&to=ff418d805ec44e288f4c8eb3150e1e874b26040c&stat=instructions

The patch can lead to slightly different (mostly better) results, because in some cases we do not run into various existing recursion limits.

I'd be curious to hear what people think about the latest version and the compile-time trade-off. It should fix a set of related crashes, linked to https://github.com/llvm/llvm-project/issues/44546. It fixes all crashes I was able to reproduce from the issue list on my local system.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114650/new/

https://reviews.llvm.org/D114650

Files:
  llvm/include/llvm/Analysis/ScalarEvolution.h
  llvm/lib/Analysis/ScalarEvolution.cpp
  llvm/test/Analysis/Delinearization/a.ll
  llvm/test/Analysis/Delinearization/multidim_ivs_and_integer_offsets_nts_3d.ll
  llvm/test/Transforms/LoopStrengthReduce/depth-limit-overrun.ll
  llvm/test/Transforms/LoopStrengthReduce/wrong-hoisting-iv.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114650.439764.patch
Type: text/x-patch
Size: 28776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220624/11858130/attachment.bin>