[PATCH] D125485: [ArgPromotion] Unify byval promotion with non-byval

Pavel Samolysov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 07:47:35 PDT 2022


psamolysov updated this revision to Diff 439755.
psamolysov marked an inline comment as done.
psamolysov added a comment.

Implement the proposed solution with `DTGetter` to reuse DominatorTrees from the pass manager. This works fine on the new PM but not on the legacy one. As a workaround, a new DominatorTree is created for every new generated function whenever the Argument Promotion Pass is used through the legacy pass manager.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125485/new/

https://reviews.llvm.org/D125485

Files:
  llvm/include/llvm/Transforms/IPO/ArgumentPromotion.h
  llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
  llvm/test/Transforms/ArgumentPromotion/align.ll
  llvm/test/Transforms/ArgumentPromotion/attrs.ll
  llvm/test/Transforms/ArgumentPromotion/byval-2.ll
  llvm/test/Transforms/ArgumentPromotion/byval-through-pointer-promotion.ll
  llvm/test/Transforms/ArgumentPromotion/byval-with-padding.ll
  llvm/test/Transforms/ArgumentPromotion/byval.ll
  llvm/test/Transforms/ArgumentPromotion/dbg.ll
  llvm/test/Transforms/ArgumentPromotion/fp80.ll
  llvm/test/Transforms/ArgumentPromotion/store-after-load.ll
  llvm/test/Transforms/ArgumentPromotion/store-into-inself.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125485.439755.patch
Type: text/x-patch
Size: 54709 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220624/02233cfb/attachment-0001.bin>


More information about the llvm-commits mailing list