[PATCH] D128495: [RISCV][MC] Fold UIMM related code

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 07:14:14 PDT 2022


luismarques added a comment.

Personally, I would just leave the raw case statements, but I don't really care that much either way.
Overall, LGTM.

BTW, I guess in C++ you can't do an alias specialization of a function template (e.g. `using isUImm2 = IsUImm<2>;`), which would avoid introducing those wrapper functions, right? I'm not really sure why that is (the equivalent thing in D just works, and the template model is similar), but I also am not sure I want to find out :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128495/new/

https://reviews.llvm.org/D128495



More information about the llvm-commits mailing list