[PATCH] D128345: [Alignment] Replace commonAlignment with std::min

Benjamin Kramer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 06:46:47 PDT 2022


bkramer added a comment.

In D128345#3607911 <https://reviews.llvm.org/D128345#3607911>, @gchatelet wrote:

> @aemerson @bkramer is `std::min(Align, Align)` clear enough?

I think so. But I find it rather confusing to have the other overload of `commonAlign` still around. Are you planning to remove that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128345/new/

https://reviews.llvm.org/D128345



More information about the llvm-commits mailing list