[PATCH] D128346: [AMDGPU] Disable the private segment size fallback to 16k

Fri Jun 24 06:43:04 PDT 2022

arsenm added a comment.

In D128346#3607596 <https://reviews.llvm.org/D128346#3607596>, @abinavpp wrote:

> Do we need to worry about non HSA platforms here? Like the behavior of AMDGPUPALMetadata::setFunctionScratchSize(). Also, the calculation of SIProgramInfo::ScratchBlocks?

I think this should be consistent everywhere. The fixed size was always an undesirable hack. I'm not sure if the shaders have a defined way to represent this though

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128346/new/

https://reviews.llvm.org/D128346