[PATCH] D127253: [AMDGPU] Use v_mad_u64_u32 for IMAD32

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 04:07:41 PDT 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/VOP3Instructions.td:591
+        (ThreeOpFragSDAG<mul, add> i32:$src0, i32:$src1, (i32 imm:$src2)),
+        (EXTRACT_SUBREG (inst $src0, $src1, (i64 (as_i64imm $src2)), 0 /* clamp */), sub0)
+        >;
----------------
This causes assertion failures if you try to form a mad with a negative immediate addend - see the test case added in D128435.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127253/new/

https://reviews.llvm.org/D127253



More information about the llvm-commits mailing list