[PATCH] D127443: [InstCombine] add zeroinitializer handling to memchr folders

[Nikita Popov via Phabricator via llvm-commits]

nikic added a reviewer: efriedma.
nikic added a comment.

I'm still not a fan of this API. You already don't implement the necessary special handling for memccpy, and in the meantime we have gained additional uses of TrimAtNul for memcmp and soon strncmp. All of these will need special code to handle the zeroinitializer case. I don't think the ability to handle unrealistically large `[2147483647 x i8] zeroinitializer` style constants is important enough to warrant the additional complexity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127443/new/

https://reviews.llvm.org/D127443