[PATCH] D127202: [InlineFunction] Handle early exit during getUnderlyingObjects due to MaxLookup
ChenZheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 24 01:51:59 PDT 2022
shchenz marked an inline comment as done.
shchenz added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1115
+ // enough to get the real underlying object.
+ if (!isIdentifiedObject(V))
+ MayAliasForUnidentify = true;
----------------
nikic wrote:
> This looks overly aggressive to me, and probably loses most of the point of the PointerMayBeCapturedBefore check. We should be classifying objects into isIdentifiedObject and isEscapeSource, where we can use the capture-based logic for isEscapeSource. (It's currently static in BasicAliasAnalysis, but can be exported.)
Thanks. Updated.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127202/new/
https://reviews.llvm.org/D127202
More information about the llvm-commits
mailing list