[PATCH] D127942: [NewGVN] add context instruction for SimplifyQuery

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 01:50:52 PDT 2022


fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:134
 // the preferred context instruction (if any).
-static const Instruction *safeCxtI(const Value *V, const Instruction *CxtI) {
+static const Instruction *safeCxtI(const Value *V, const Instruction *CxtI,
+                                   bool UseInstrInfo) {
----------------
it seems it would be slightly simpler to move `safeCxtI` to `SimplifyQuery`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127942/new/

https://reviews.llvm.org/D127942



More information about the llvm-commits mailing list