[PATCH] D128481: Add expensive/extensive pass to set Load/Store alignment

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:63
-                        OptimizationRemarkEmitter *ORE = nullptr,
-                        bool UseInstrInfo = true);
 
----------------
I'd suggest to pre-commit a clang-format of this header.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1928
+  if (Q.KnownValues) {
+    auto it = Q.KnownValues->find(V);
+    if (it != Q.KnownValues->end()) {
----------------
nit: It


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128481/new/

https://reviews.llvm.org/D128481