[PATCH] D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis.

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 24 00:59:53 PDT 2022


kazu accepted this revision.
kazu added a comment.
This revision is now accepted and ready to land.

LGTM with a minor comment fix.  Thanks!



================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:63
+             "with LTO phase information. Relevant inline instances include "
+             "CGSCCInliner, ModuleInliner, ReplayInliner. Support for missed "
+             "inline remarks needs to be added."));
----------------
Insert 'and' like `ModuleInliner, and ReplayInliner`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125495/new/

https://reviews.llvm.org/D125495



More information about the llvm-commits mailing list