[PATCH] D122539: [SelectionDAG][DAGCombiner] Reuse exist node by reassociate

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1039
+        AM.HasBaseReg = true;
+        AM.BaseOffs = C2APIntVal.getSExtValue();
+        EVT VT = LoadStore->getMemoryVT();
----------------
We have a C2APIntVal use here that I don't think has a getSignificantBits check?


================
Comment at: llvm/test/Transforms/Reassociate/pr56170.ll:4
+
+define void @reassociation_gt64bit(i32 %x, i32 %y, ptr %s) {
+; CHECK-LABEL: reassociation_gt64bit:
----------------
Shouldn't this be in tests/Codegen/X86?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122539/new/

https://reviews.llvm.org/D122539