[PATCH] D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/Object/ELF.cpp:670-671
+      if (Version > 1)
+        return createError("unsupported LLVM_BB_ADDR_MAP version: " +
+                           Twine(static_cast<int>(Version)));
+      Data.getU8(Cur); // Feature byte
----------------
jhenderson wrote:
> Test case?
> 
> Also, the type is "SHT_LLVM_BB_ADDR_MAP", so probably wants to include the SHT_ too, to match (and be consistent with other error messages)
Looks like there's still no test case?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/bb-addr-map.test:124
             Metadata:      0x8
-  - Name:   dummy_section
-    Type:   SHT_PROGBITS
-    Size:   16
-  - Name:   bb_addr_map_2
-    Type:   SHT_LLVM_BB_ADDR_MAP
-    Link:   .text.bar
+  - Name:  dummy_section
+    Type:  SHT_PROGBITS
----------------
FWIW, there are still 2 spaces here, rather than just 1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121346/new/

https://reviews.llvm.org/D121346