[PATCH] D128474: [BOLT] Support multiple parents for split jump table

[Amir Ayupov via Phabricator via llvm-commits]

Amir added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:631
 
-    if (!BF.isSimple())
+    if (!JT->Parents[0]->isSimple())
       continue;
----------------
I think checking if the first parent is non-simple is fine, but a future-proof solution would be to check if any of parents is non-simple. 


================
Comment at: bolt/lib/Core/BinaryContext.cpp:664
+        if (EntryOffset == Frag->getAddress() + Frag->getSize())
+          Frag->IgnoredBranches.emplace_back(EntryOffset - Frag->getAddress(),
+                                             Frag->getSize());
----------------
Let's add curly braces in if and else bodies


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128474/new/

https://reviews.llvm.org/D128474