[PATCH] D118566: [LoopVectorizer] Don't perform interleaving of predicated scalar loops

[Tiehu Zhang via Phabricator via llvm-commits]

TiehuZhang added a comment.

In D118566#3605004 <https://reviews.llvm.org/D118566#3605004>, @dmgreen wrote:

> Hello.
>
> Hmm. I remember that this was important for performance in some cases on AArch64 - but we don't enable AggressivelyInterleaveReductions. If you have examples of scalar interleaving causing performance problems with AggressivelyInterleaveReductions then it sounds sensible to me to disable it for the if you pointed to as well.

OK, thank! I'll try to extract an example from the benchmark to illustrate my point.  By the way, I wonder why the patch does not return 1 after detecting that ScalarInterleavingRequiresPredication is true. Is this patch not intended to filter all predicated scalar loops?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118566/new/

https://reviews.llvm.org/D118566