[PATCH] D128024: [llvm-diff] Fix false alarm on PHI node
Yilong Guo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 23 18:47:50 PDT 2022
Nuullll added inline comments.
================
Comment at: llvm/tools/llvm-diff/lib/DifferenceEngine.cpp:594
+ return Values[L] == R || TentativeValues.count(std::make_pair(L, R)) ||
+ !diff(cast<Instruction>(L), cast<Instruction>(R), false, false);
----------------
fhahn wrote:
> Does this handle cycles in phi nodes correctly? It would be good to at least have a couple of tests with cycles.
Thanks a lot for reviewing!
This actually is causing infinite recursions for cycled phi nodes.
I'll reconsider the algorithm.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128024/new/
https://reviews.llvm.org/D128024
More information about the llvm-commits
mailing list