[PATCH] D128474: [BOLT] Support multiple parents for split jump table

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 23 18:04:45 PDT 2022


rafauler added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:644-647
+      dbgs() << "failed to analyze jump table in function ";
+      for (BinaryFunction *Frag : JT->Parents)
+        dbgs() << LS << *Frag;
+      dbgs() << '\n';
----------------
debug code should be guarded under the LLVM_DEBUG macro in the same way as line 625. This line was previously unguarded by mistake.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:651-656
         dbgs() << "next jump table at 0x"
                << Twine::utohexstr(NextJTI->second->getAddress())
-               << " belongs to function " << *NextJTI->second->Parent << '\n';
+               << " belongs to function ";
+        for (BinaryFunction *Frag : NextJTI->second->Parents)
+          dbgs() << LS << *Frag;
+        dbgs() << "\n";
----------------
same


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128474/new/

https://reviews.llvm.org/D128474



More information about the llvm-commits mailing list