[PATCH] D125212: [GlobalISel] Implement the HasNoUse builtin predicate

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h:392
+      assert(MI->getNumDefs() > 0 && "No defs");
+      const Register Res = MI->getOperand(0).getReg();
+
----------------
Ideally this would be for a specific operand index, but it would be a bit hard to test since we still can't write patterns with other defs


================
Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:803
 
+  // TODO: Support this in SelectionDAG.
+  // If set to true, a predicate is added that checks for the absence of use of
----------------
Not sure how you can avoid supporting it here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125212/new/

https://reviews.llvm.org/D125212