[PATCH] D121346: [Propeller] Encode address offsets of basic blocks relative to the end of the previous basic blocks.

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added inline comments.


================
Comment at: llvm/test/CodeGen/X86/basic-block-sections-labels-functions-sections.ll:13
 ; CHECK:		.section .llvm_bb_addr_map,"o", at llvm_bb_addr_map,.text._Z3barv{{$}}
-; CHECK-NEXT:		.quad [[BAR_BEGIN]]
+; CHECK:		.quad [[BAR_BEGIN]]
 
----------------
jhenderson wrote:
> Should we instead be including the version etc bytes? (I don't mind, just trying to understand the thought process)
You're right. We can do that.


================
Comment at: llvm/test/tools/obj2yaml/ELF/bb-addr-map.yaml:133-135
+      - Version:  0
+        Feature:  0x0
+        Address:  0x0
----------------
jhenderson wrote:
> rahmanl wrote:
> > jhenderson wrote:
> > > Any particular reason you have a double space between the colon and value here and below?
> > It should be 3 spaces because of `NumBlocks` being used sometime. Aligned the YAML keys in this test more carefully.
> FWIW, I only align within the individual block, so here, I'd align with only the single space, and then use 3 spaces where NumBlocks is present. I don't care really though, as long as the spacing doesn't get excessive (at which point it can make readability an issue).
Thanks. Adopted your approach.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121346/new/

https://reviews.llvm.org/D121346