[PATCH] D128435: [AMDGPU] Fix assertion failure on mad with negative immediate addend

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp:545
+  else
+    O << formatHex(Imm);
 }
----------------
foad wrote:
> Perhaps I should truncate Imm to 32 bits here. I'm not sure.
I think the truncation should be done at selection time. Ideally the verifier would enforce this (plus we should try to handle the s_mov_b64 case the comment references)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128435/new/

https://reviews.llvm.org/D128435