[PATCH] D128451: [lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file>

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/ELF/Options.td:411
 
-def time_trace: FF<"time-trace">, HelpText<"Record time trace">;
-def time_trace_file_eq: JJ<"time-trace-file=">, HelpText<"Specify time trace output file">;
+def time_trace_eq: JJ<"time-trace=">, MetaVarName<"<file>">,
+  HelpText<"Record time trace to <file>">;
----------------
thakis wrote:
> MaskRay wrote:
> > Use `def time_trace`
> why? it's an _eq option, no?
Using `_eq` looks good. 


================
Comment at: lld/docs/ReleaseNotes.rst:44
   (`D126793 <https://reviews.llvm.org/D126793>`_)
+* The ``--time-trace-file=<file>`` flag is gone,
+  replaced by ``--time-trace=<file>``.
----------------
```
``--time-trace-file=<file>`` has been removed. Use ``--time-trace=<file>`` instead.
(`D128451 <https://reviews.llvm.org/D128451>`_)
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128451/new/

https://reviews.llvm.org/D128451