[PATCH] D127932: [TableGen] Add a knob for MCOperandInfo expansion in gen-instr-info

Thu Jun 23 10:36:22 PDT 2022

Amir marked an inline comment as done.
Amir added inline comments.

================
Comment at: llvm/test/TableGen/get-operand-type-no-expand.td:41
+
+// RUN: llvm-tblgen -gen-instr-info -I %p/../../include %s \
+// RUN:   -instr-info-expand-mi-operand-info=0 \
----------------
skan wrote:
> Do we need to test that `-instr-info-expand-mi-operand-info=1`  while `-gen-instr-info` is not enabled?
I don't think so. `-instr-info-expand-mi-operand-info=1` only has an effect when `gen-instr-info` is enabled.

================
Comment at: llvm/test/TableGen/get-operand-type-no-expand.td:47
+// CHECK-NOEXPAND:        /* InstA */
+// CHECK-NOEXPAND-NEXT:   i512complex, i8complex, i32imm,
+// CHECK-NOEXPAND: #endif // GET_INSTRINFO_OPERAND_TYPE
----------------
skan wrote:
> Question: i512complex is expanded to what above?
i8complex and i512complex both expand into `(ops i8imm, i32imm)` according to ComplexOperand definition. Similar to X86MemOperand that expands into a fixed MIOperandInfo DAG.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127932/new/

https://reviews.llvm.org/D127932