[PATCH] D124926: [LoopInterchange] New cost model for loop interchange

Thu Jun 23 08:41:53 PDT 2022

congzhe added a comment.

In D124926#3599795 <https://reviews.llvm.org/D124926#3599795>, @congzhe wrote:

> After D127342 <https://reviews.llvm.org/D127342> is merged, we could try to reland this patch, by providing `-cache-line-size=64` for each loop interchange test case. I've updated the patch accordingly.
>
> I did not remove the `target datalayout` lines for the moment. As Michael pointed out, it represents the pointer size and so on. I actually tried to remove those lines but I hit one test failure in `phi-ordering.ll` (a SCEV crash in loop cache analysis). As Florian mentioned earlier, there should be some bug within loop cache analysis, and I'll look into it in my next patch as promised. For now I'm thinking we could try to get this patch landed firstly.
>
> Comments are appreciated :)

Hi Bardia, I'm wondering if you have further comments on this most recent version? @bmahjour

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124926/new/

https://reviews.llvm.org/D124926