[PATCH] D127580: [VPlan] Remove dead recipes across whole plan.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:593
-  case VPBranchOnMaskSC:
-    return false;
   case VPWidenIntOrFpInductionSC:
----------------
Ayal wrote:
> Hmm, bug fix? Is there a test that checks it?
Yes, it is covered by the existing tests. Without it, removeDeadRecipes would now remove branchonmask, which would cause issues.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.h:53
 
-  /// Try to remove dead recipes. At the moment, only dead header recipes are
-  /// removed.
+  /// Try to remove dead recipes from \p Plan.
   static void removeDeadRecipes(VPlan &Plan);
----------------
Ayal wrote:
> nit: comment seems redundant, remove or extend?
Removed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127580/new/

https://reviews.llvm.org/D127580