[PATCH] D125669: Adding support for target in_reduction

Thu Jun 23 03:23:30 PDT 2022

RitanyaB marked an inline comment as done.
RitanyaB added a comment.

In D125669#3599134 <https://reviews.llvm.org/D125669#3599134>, @ABataev wrote:

> What about the description? Shall we still emit ` if(0)`?

Can you please elaborate for more clarity?

================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5035-5039
+    llvm::APInt TrueOrFalse(32,
+                            S.hasClausesOfKind<OMPInReductionClause>() ? 0 : 1);
+    IntegerLiteral IfCond(getContext(), TrueOrFalse,
+                          getContext().getIntTypeForBitwidth(32, /*Signed=*/0),
+                          SourceLocation());
----------------
ABataev wrote:
> Why integer, not a boolean? Also, this is currently meaningless, since these 2 vars are not visible outside of the if context.
Thank you for the suggestion. I have removed the if block. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125669/new/

https://reviews.llvm.org/D125669