[llvm] aa5492e - [GlobalISel][TableGen] Qualify calls to llvm::format that have ::std:: types as parameters

Casey Carter via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 21:37:49 PDT 2022


Author: Charlie Barto
Date: 2022-06-22T21:37:40-07:00
New Revision: aa5492e7b218b7c79bf975ff751631392b03cecf

URL: https://github.com/llvm/llvm-project/commit/aa5492e7b218b7c79bf975ff751631392b03cecf
DIFF: https://github.com/llvm/llvm-project/commit/aa5492e7b218b7c79bf975ff751631392b03cecf.diff

LOG: [GlobalISel][TableGen] Qualify calls to llvm::format that have ::std:: types as parameters

... to avoid ambiguity in overload resolution when ADL finds `std::format`.

Differential Revision: https://reviews.llvm.org/D119213

Added: 
    

Modified: 
    llvm/utils/TableGen/GlobalISel/GIMatchDag.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/utils/TableGen/GlobalISel/GIMatchDag.cpp b/llvm/utils/TableGen/GlobalISel/GIMatchDag.cpp
index 7e037dd03b601..8be32d2effa6e 100644
--- a/llvm/utils/TableGen/GlobalISel/GIMatchDag.cpp
+++ b/llvm/utils/TableGen/GlobalISel/GIMatchDag.cpp
@@ -48,7 +48,7 @@ void GIMatchDag::writeDOTGraph(raw_ostream &OS, StringRef ID) const {
          << Assignment.first << ")";
       Separator = ", ";
     }
-    OS << format("|%p|", &N);
+    OS << llvm::format("|%p|", &N);
     writePorts("d", N->getOperandInfo());
     OS << "}\"";
     if (N->isMatchRoot())
@@ -82,7 +82,7 @@ void GIMatchDag::writeDOTGraph(raw_ostream &OS, StringRef ID) const {
     writePorts("s", N->getOperandInfo());
     OS << "|" << N->getName() << "|";
     N->printDescription(OS);
-    OS << format("|%p|", &N);
+    OS << llvm::format("|%p|", &N);
     writePorts("d", N->getOperandInfo());
     OS << "}\",style=dotted]\n";
   }


        


More information about the llvm-commits mailing list