[PATCH] D114419: [XCOFF] change default program code csect alignment to 32

[Esme Yi via Phabricator via llvm-commits]

Esme added a comment.

I have no more comments other than some nits.



================
Comment at: llvm/include/llvm/MC/MCSectionXCOFF.h:62
+    if (ST != XCOFF::XTY_ER) {
+      // A csect for program code, set the align to 32 by default. For other
+      // csect, set the align to 4 by default.
----------------



================
Comment at: llvm/include/llvm/MC/MCSectionXCOFF.h:63
+      // A csect for program code, set the align to 32 by default. For other
+      // csect, set the align to 4 by default.
+      if (SMC == XCOFF::XMC_PR)
----------------



================
Comment at: llvm/test/CodeGen/PowerPC/aix-emit-tracebacktable-clobber-register.ll:92
 ; COMMON-NEXT:  .vbyte  4, 0
-; CHECK-ASM-NEXT:  .csect .text[PR],2
-; CHECK-FUNC-NEXT:  .csect .foov[PR],2
+; CHECK-ASM-NEXT:  .csect .text[PR],5
+; CHECK-FUNC-NEXT:  .csect .foov[PR],5
----------------



================
Comment at: llvm/test/CodeGen/PowerPC/aix-emit-tracebacktable.ll:177
 ; CHECK-ASM-LABEL:     .main:{{[[:space:]] *}}# %bb.0:
-; CHECK-FUNC-LABEL:   .csect .main[PR],2{{[[:space:]] *}}# %bb.0
+; CHECK-FUNC-LABEL:   .csect .main[PR],5{{[[:space:]] *}}# %bb.0
 ; COMMON-NEXT:   mflr 0
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114419/new/

https://reviews.llvm.org/D114419