[PATCH] D124654: [AIX] Handling the label alignment of a global variable with its multiple aliases.

[Esme Yi via Phabricator via llvm-commits]

Esme updated this revision to Diff 439176.
Esme edited the summary of this revision.
Esme added a comment.

Thank you for your comments. @shchenz
I had a misunderstanding about the behavior of label alignment on AIX. 
Please ignore my previous replies. I've addressed your comments in this update.

1. Emit the label of the alias just before emitting the value of the sub-element that the alias referred to.
2. Emit the linkage of alias together with the global variable‘s, that is, before labels and values, although there is no impact on the functionality I think this is more appropriate.
3. Remove the test case that is unnecessary for the current patch.
4. Check the symbol table after assembling the assembly to verify no space allocation regression.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124654/new/

https://reviews.llvm.org/D124654

Files:
  llvm/include/llvm/CodeGen/AsmPrinter.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
  llvm/test/CodeGen/PowerPC/aix-alias-alignment.ll
  llvm/test/CodeGen/PowerPC/aix-alias.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124654.439176.patch
Type: text/x-patch
Size: 14345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220623/ccf848b3/attachment.bin>