[PATCH] D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information.
Kazu Hirata via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 22 14:38:38 PDT 2022
kazu accepted this revision.
kazu added a comment.
This revision is now accepted and ready to land.
LGTM with a minor change to the constructor of `InlineAdvisor`. Thank you for your patience.
================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:512
+ : M(M), FAM(FAM), IC(IC),
+ AnnotatedInlinePassName(IC.hasValue()
+ ? llvm::AnnotateInlinePassName(IC.getValue())
----------------
Replace `IC.hasValue()` with `TC`.
================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:513
+ AnnotatedInlinePassName(IC.hasValue()
+ ? llvm::AnnotateInlinePassName(IC.getValue())
+ : DEBUG_TYPE) {
----------------
Replace `IC.getValue()` with `*IC`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126833/new/
https://reviews.llvm.org/D126833
More information about the llvm-commits
mailing list