[PATCH] D127119: [SLP]Fix undef handling in gather function.

Vasileios Porpodas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 12:20:23 PDT 2022


vporpo added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8826
+        }
+        if (CV2 && isa<UndefValue>(CV2->getAggregateElement(SM1[I] % E)) &&
+            (isGuaranteedNotToBePoison(SI2->getOperand(NewMask[I] / E)) ||
----------------
These `->getAggregateElement(...)` and `->getOperand(...)` expressions repeat several times in the code and make this code quite verbose.  Is there a way to avoid this repetition?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127119/new/

https://reviews.llvm.org/D127119



More information about the llvm-commits mailing list