[PATCH] D128344: [AMDGPU] Add the "is_dynamic_callstack" of amd_kernel_code_t to the kernel descriptor

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl requested changes to this revision.
kzhuravl added a comment.
This revision now requires changes to proceed.

Do we want to tie this bit to a particular code object version? Code object v4 and up? Why did you pick code object v3 and up?



================
Comment at: llvm/docs/AMDGPUUsage.rst:4003
+                                                     dynamically sized call stack.
+     463:460 1 bit                                   Reserved, must be 0.
      464     1 bit   RESERVED_464                    Deprecated, must be 0.
----------------
If it is "Reserved, must be 0.", then compiler does not set it. But you clearly set it in in AsmPrinter


================
Comment at: llvm/include/llvm/Support/AMDHSAKernelDescriptor.h:165
   KERNEL_CODE_PROPERTY(RESERVED1, 11, 5),
+  KERNEL_CODE_PROPERTY(IS_DYNAMIC_CALLSTACK, 20, 1),
 };
----------------
Why not eat up the reserved bit at index 11 and decrease number of reserved bits to 4?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128344/new/

https://reviews.llvm.org/D128344