[PATCH] D128346: [AMDGPU] Set scratch size to 0 if is_dynamic_callstack is set

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

This should remove the amdgpu-assume-external-call-stack-size and  amdgpu-assume-dynamic-stack-object-size flags too



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:698-699
+      Info.HasDynamicallySizedStack || Info.HasRecursion;
+  ProgInfo.ScratchSize =
+      ProgInfo.DynamicCallStack ? 0 : Info.PrivateSegmentSize;
   ProgInfo.VCCUsed = Info.UsesVCC;
----------------
Dynamic call size does not imply 0 for the statically reported size. We still need to report the minimum statically known requirement


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128346/new/

https://reviews.llvm.org/D128346