[PATCH] D125795: [IR] Remove support for extractvalue constant expression

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

In D125795#3599173 <https://reviews.llvm.org/D125795#3599173>, @nikic wrote:

> In D125795#3598460 <https://reviews.llvm.org/D125795#3598460>, @nhaehnle wrote:
>
>> I'm in favor of doing this, and the change looks mostly straightforward. However, I wonder if, since it is a breaking change in the C ABI, we shouldn't have at least one release cycle where `LLVMConstExtractValue` (and other functions that are planned to be removed) are marked as deprecated.
>
> I don't think that's necessary. Per https://llvm.org/docs/DeveloperPolicy.html#c-api-changes C API stability is "best effort", presumably exactly for cases like this (the underlying functionality that is being exported simply no longer exists). I don't think unavoidable changes to the C API should hold back changes, especially as the impact on the C and C++ APIs is the same here. Of course, we should have a release note for the change, which I have now added.

Yeah, that's fair.

> Less relevant for extractvalue, but possibly for other constant expressions, do we need to export any of the `ConstantFoldXYZ` APIs? Those would be the fallible replacements for `LLVMConstXYZ`.

I doubt it. The C API already has LLVMBuildXYZ functions which will do constant folding.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125795/new/

https://reviews.llvm.org/D125795