[PATCH] D126378: [SLP]Fix crash on reordering of ScatterVectorize nodes.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/scatter-vectorize-reorder.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S -slp-vectorizer -mtriple=x86_64-unknown-linux-gnu -mcpu=cascadelake < %s | FileCheck %s
+
----------------
vdmitrie wrote:
> It seems the test does not actually execute the change. At this state it did not crash before the patch.
> You probably wanted "skylake" here (i.e. an AVX2 with fast gather) instead of cascadelake . Otherwise TTI's forceScalarizeMaskedGather would return true and we really do not have any ScatterVectorize nodes in the tree.
Just probably it was committed before the patch that added forceScalarizeMaskedGather check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126378/new/

https://reviews.llvm.org/D126378