[PATCH] D124865: [AIX] support read global symbol of big archive
Digger Lin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 22 06:11:20 PDT 2022
DiggerLin added a comment.
In D124865#3601036 <https://reviews.llvm.org/D124865#3601036>, @jhenderson wrote:
> I feel like this code is missing testing for the non-error cases. In particular, I'd expect to see some sort of test that shows that the archive symbol table can be read successfully. I think you can do that using `llvm-nm --print-armap`. I'd be surprised if there aren't already equivalent test cases for other formats that do this, so you may be able to copy/modify those to cover big archives too.
There is already has "llvm-nm --print-armap" in the llvm/test/tools/llvm-ar/delete.test , the test case is disable in AIX OS, it enable in AIX in the patch by deleting the "# XFAIL: system-aix"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124865/new/
https://reviews.llvm.org/D124865
More information about the llvm-commits
mailing list