[PATCH] D128334: [LegalizeTypes][X86] Add SoftPromoteHalfOperand support for STRICT_FP_TO_SINT/STRICT_FP_TO_UINT

Wed Jun 22 05:45:57 PDT 2022

pengfei added inline comments.

================
Comment at: llvm/test/CodeGen/X86/fp16-promote-strict.ll:2-3
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-linux-android -mattr=+sse | FileCheck %s --check-prefixes=X64-SSE
+; RUN: llc < %s -mtriple=x86_64-linux-gnu -mattr=+sse | FileCheck %s --check-prefixes=X64-SSE
+; RUN: llc < %s -mtriple=x86_64-linux-android -mattr=+avx512fp16 | FileCheck %s --check-prefixes=X64-AVX512
----------------
Does it intend to check sse only? The `x86_64` will enable `+sse2` by default.

================
Comment at: llvm/test/CodeGen/X86/fp16-promote-strict.ll:6
+; RUN: llc < %s -mtriple=x86_64-linux-gnu -mattr=+avx512fp16 | FileCheck %s --check-prefixes=X64-AVX512
+; RUN: llc < %s -mtriple=i686-linux-gnu -mattr=-sse | FileCheck %s --check-prefixes=X86
+
----------------
We have made `half` a legal type on SSE2 and above targets now. So they won't go into the `SoftPromoteXXX` anymore.
For targets before SSE2, both GCC and Clang have decided to drop the support for `half` type, because we can't make the ABI compatible with the later targets.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128334/new/

https://reviews.llvm.org/D128334