[PATCH] D128029: [AArch64] Add target feature "all"

[Sam Elliott via Phabricator via llvm-commits]

lenary added a comment.

I'm very supportive of this, as I wanted it the other day.

I do agree this should not be exposed through `-march` - instead it should be exposed only through `--mattr` which I feel is not quite as user-facing as `-march` and friends.

I wonder whether a better approach to reduce the maintenance burden might be the following:

  def FeatureAll : SubtargetFeature<"all", "IsAll", "true", "Enable all instructions", []>;
  
  // or for AArch64
  class ARMAssemblerPredicate<dag cond, string name=""> : AssemblerPredicate<(any_of FeatureAll, cond), name>;

This might even be something to move into `llvm/include/llvm/Target/Target.td` (I don't know, by changing `class AssemblerPredicate` to `class AssemblerPredicateBase` and then calling what i've defined as `ARMAssemblerPredicate` as `AssemblerPredicate`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128029/new/

https://reviews.llvm.org/D128029