[PATCH] D128141: [MemProf] Basic metadata support and verification

Mingjie Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 22 01:36:03 PDT 2022


Enna1 added inline comments.


================
Comment at: llvm/test/Verifier/memprof-metadata-good.ll:29
+!2 = !{i64 123, i64 456}
+!3 = !{!4, !"cold", !"tag3", !"tag4"}
+!4 = !{i64 123, i64 789, i64 678}
----------------
IIUC, does this !4 = !{i64 123, i64 789, i64 678} means we have a call stack: test3() -> test1() -> malloc()
If so, the callee in `test3()` should be `test1()` instead of `test2()` ? :
```
define i32* @test3() {
entry:
  %call = call noundef i32* @test1(), !callsite !7
  ret i32* %call
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128141/new/

https://reviews.llvm.org/D128141



More information about the llvm-commits mailing list